Conversation
edvilme
added
area-terminal
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the Python: Create Terminal command behavior to better support multi-root workspaces by selecting an appropriate Python project before creating a terminal.
Changes:
- Cache
api.getPythonProjects()and reuse it during terminal creation. - Update the project-picking flow in
createTerminalCommand. - Update
package-lock.jsonwith additionalpeermetadata entries.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/features/envCommands.ts | Updates project selection logic used when creating terminals. |
| package-lock.json | Adds peer: true metadata to multiple dependency entries. |
| "integrity": "sha512-D7DbgGFtsqIPIFMPJwCad9Gfi/hC0PWErRRHFnaCWoEDYi5tQUDiJCTmGUbBiLzjqAck4KcXt9Ayj0CNlIrF+w==", | ||
| "dev": true, | ||
| "license": "BSD-2-Clause", | ||
| "peer": true, |
Member
There was a problem hiding this comment.
any idea why this had changes to the package lock file?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #291
This pull request updates the logic for creating terminal commands related to Python environments, focusing on how Python projects are retrieved and passed to the
pickProjectfunction. The changes improve consistency and clarity in how project lists are handled.Improvements to project selection logic: